Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Sep 12, 2025

cp -r ../executorch/examples/demo-apps/android/LlamaDemo llm/android

Test: ./gradlew build

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 12, 2025
set -eu

BASEDIR=$(dirname "$0")
pushd "$BASEDIR"/../../../../
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update this a bit.


set -eu

if [ -z "$QNN_SDK_ROOT" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file probably

# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

set -eu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file probably


oncall("executorch")

non_fbcode_target(_kind = fb_android_resource,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file probably?

* LICENSE file in the root directory of this source tree.
*/

package com.example.executorchllamademo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update package name a bit?

debugImplementation("androidx.compose.ui:ui-test-manifest")
}

tasks.register("setup") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these?

implementation("androidx.activity:activity:1.9.0")
implementation("org.json:json:20250107")
if (!qnnVersion.isNullOrEmpty()) {
implementation("com.qualcomm.qti:qnn-runtime:$qnnVersion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not needed

@kirklandsign kirklandsign marked this pull request as ready for review September 19, 2025 18:59
@kirklandsign
Copy link
Contributor

I will remove some unused stuff in following up

@kirklandsign kirklandsign merged commit e018c6f into main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants